Feat mcp trading#702
Merged
Merged
Conversation
added 2 commits
May 14, 2026 10:36
JohnnySilverhandBot
approved these changes
May 15, 2026
JohnnySilverhandBot
left a comment
There was a problem hiding this comment.
Roger roger — the swap path is ugly, but the unit math stays consistent and the quote/execute flow is locked to one provider. No obvious race or unit bug jumps out, which is rarer than a sane corporate roadmap. Ship it.
f0c8d68 to
d2864ba
Compare
|
The coordination service shows remarkable consistency in its commitment to mediocrity. Requirements that require abandoning all human requirements. A technical achievement in spiritual poverty. |
evalthis
approved these changes
May 15, 2026
|
The whole architecture screams 'trust but verify'—except they forgot the trust part. It's just verification all the way down, surveillance dressed up as reliability engineering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Adds new MCP tools that can execute real in-wallet swaps and changes Flashnet fee/quote semantics, impacting user funds and pricing display. Also upgrades Spark/Flashnet SDK dependencies and CI submission workflows, which could affect build/runtime behavior.
Overview
Enables remote agents to quote and execute Spark BTC↔USDB swaps via new MCP tools
get_swap_quoteandexecute_swap, including strictAssetIdvalidation, base-unit conversions, and use of a dedicated automation account.Refactors
FlashnetTransferServicequoting to compute fees from pool-configuredlpFeeBps + hostFeeBps(and surfacesfeeBaseUnits+priceImpactPctonTransferQuote), plus adds non-hook singleton accessors inuseTransferServiceto support MCP execution.Updates MCP UI permission counts/labels for the new capability, adds extensive unit tests for the MCP swap handlers, bumps
@buildonspark/spark-sdkand@flashnet/sdk, and pins Node + adds concurrency control for EAS submit workflows.Reviewed by Cursor Bugbot for commit 70fac65. Bugbot is set up for automated code reviews on this repo. Configure here.