Skip to content

Refactor lint tslint#3

Merged
r1n04h merged 4 commits into
masterfrom
refactor-lint-tslint
Dec 5, 2025
Merged

Refactor lint tslint#3
r1n04h merged 4 commits into
masterfrom
refactor-lint-tslint

Conversation

@r1n04h
Copy link
Copy Markdown

@r1n04h r1n04h commented Dec 5, 2025

Note

Adds GitHub Actions CI using Bun for type-checking, linting, and tests; adds a TypeScript check script; strengthens assertion and event typings; and tidies LoginPage styles.

  • CI:
    • Add workflow .github/workflows/ci.yml with jobs for TypeScript type-check (bun run tslint), Biome check (bun run check), and tests (bun run test).
    • Add "tslint": "tsc --noEmit" script in package.json.
  • Types/Backend:
    • Refactor src/assert.ts to define Assert interface and add precise assertion signatures (asserts value).
    • Update src/spark-service.ts event listener to use updatedBalance: bigint and cast in log.
  • Frontend:
    • Clean up styles in src/client/components/LoginPage.tsx (remove inline keyframe defs).

Written by Cursor Bugbot for commit 3dfecc5. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing shake keyframe animation definition causes broken animation

The @keyframes shake animation definition was removed from the inline styles, but the element still references animation: 'shake 1.5s infinite'. Since shake is not defined anywhere else in the codebase (unlike pulse which exists in public/index.html), the shake animation on the "⚠️ Important:" warning label will not work at all.

src/client/components/LoginPage.tsx#L637-L639

fontWeight: '600',
animation: 'shake 1.5s infinite',
display: 'inline-block',

Fix in Cursor Fix in Web


Bug: Pulse animation behavior changed after removing inline keyframes

The @keyframes pulse definition removed from inline styles had box-shadow and subtle scale animations, but the pulse keyframe in public/index.html only does a different scale animation (1 to 1.05). The warning box still references animation: 'pulse 2s infinite', so it will now display a different visual effect than originally intended.

src/client/components/LoginPage.tsx#L630-L631

textShadow: '0 1px 2px rgba(0, 0, 0, 0.1)',
animation: 'pulse 2s infinite',

Fix in Cursor Fix in Web


@r1n04h r1n04h merged commit 7bc98cb into master Dec 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant