Removing the assumption that the cssLint config is in the cwd #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @mike-engel, sorry it took me so long to get around to this. Seems simple enough, but one question: does it break stuff? |
Author
|
@lazd I haven't fully tested it. In theory though, it shouldn't. The only caveat I could see is that if someone was just specifying a file in the current directory without the |
Owner
|
Yeah, that makes sense. It might still work, I'd have to test it to know, honestly, and it may depend on where you invoke gulp from... |
Owner
|
@mike-engel what do you think about #17 ? |
Author
|
@lazd Works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #13.