Automatically lookup .ccslintrc #17
Conversation
|
@lazd ping 😄 |
There was a problem hiding this comment.
Looks like we lose support for passing a rules configuration to the plugin as documented here.
|
Looks like this will require some updates to README.md to document how to use this. I'm +1 to drop passing a string path to the |
|
Hmm, I agree that should be possible, but isn't it? There's a unit-test for it. Although when I look at it, the linline rule is the same as the one in the rc file. Faulty test, I'll try chaning up one of the rules. EDIT: @lazd if you look in the |
There was a problem hiding this comment.
Options should still work
|
@lazd Rcloader supports both string and object with options: https://www.npmjs.com/package/rcloader#options |
There was a problem hiding this comment.
Ah, I see options is passed to RcLoader here, nice.
|
@SimenB I see my concern wasn't valid, you were already passing After the README is in shape, I think we're good to merge. Thanks! |
|
@lazd Something like that? I'm unsure how to formulate it 😆 |
There was a problem hiding this comment.
Nice one, most people blow away that whitespace and it makes me sad :)
There was a problem hiding this comment.
Yeah, that's why I usually add it to PRs when making them. IDEs really enjoy strpping that whitespace...
|
I think the README updates you added are good enough to merge, I can re-arrange it after merge. Let's figure out the best way to handle |
|
|
|
I think we're fine with |
|
Great, thanks! |
|
@lazd Could you |
|
@SimenB merging a couple other PRs and I'll get a release out today! |
|
Awesome 😄 |
|
Hey @SimenB, the README is still referencing passing the path to |
|
@lazd It's still supported, although it I suppose the recommended way is automatic lookup? This change should be backwards compatible. |
|
Alright, I suppose we can leave it for now. Let's consider dropping it for 1.0. |
2 participants
Fix #3
Renamed the file to .csslintrc. Is that okay?