fix: prevent cross-wallet authority deletion in RemoveAuthority (Issue #3)#25
Merged
Merged
Conversation
…#3) - Add wallet validation for target authority in process_remove_authority - Ensures target_header.wallet matches wallet_pda before any role checks - Prevents malicious owners from deleting authorities from other wallets - Add comprehensive E2E test coverage for cross-wallet attack scenarios - Tests verify Owner cannot remove/add authorities or execute on other wallets Security Impact: - CRITICAL: Fixes cross-wallet authority deletion vulnerability - Blocks unauthorized access to other wallet's authorities - Prevents DoS via mass authority deletion - Eliminates privilege escalation attack vector Fixes #3
onspeedhp
added a commit
that referenced
this pull request
Apr 7, 2026
…et-vulnerability fix: prevent cross-wallet authority deletion in RemoveAuthority (Issue #3)
onspeedhp
added a commit
that referenced
this pull request
Apr 7, 2026
…et-vulnerability fix: prevent cross-wallet authority deletion in RemoveAuthority (Issue #3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Impact: