You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: PDF files not deployed to GitHub Pages (#226)
## Summary
- Fixed PDF deployment issue where files were missing from GitHub Pages
(404 errors)
- Root cause: FORD was wiping build/doc directory before media files
could be preserved
- Solution: Moved media file copying to occur AFTER FORD generation in
make doc target
## Technical Details
The `make doc` target was copying media files to
`build/doc/media/examples` before running FORD, but FORD clears the
entire `build/doc` directory when generating documentation. This meant
PDF files were copied and then immediately removed.
**Before:**
1. Copy media files to build/doc/media/examples
2. Run FORD (wipes build/doc directory)
3. Media files are gone
**After:**
1. Run FORD to generate documentation structure
2. Copy media files to build/doc/media/examples
3. Media files are preserved in final deployment
## Testing
Verified locally that:
- `make example ARGS="scale_examples"` generates PDFs in output/
- `make doc` preserves PDFs in build/doc/media/examples/
- URL structure matches GitHub Pages expectations
The example PDF mentioned in issue #224:
`https://lazy-fortran.github.io/fortplot/media/examples/scale_examples/log_scale.pdf`
Should now be accessible once deployed.
## Impact
Fixes all PDF download links in the documentation that were returning
404 errors.
Closes#224
0 commit comments