Skip to content

bug: PDF files not deployed to GitHub Pages (404 errors) #224

@krystophny

Description

@krystophny

Bug Description

PDF files are generated correctly during the documentation build but are not accessible at their GitHub Pages URLs, resulting in 404 errors for all PDF download links.

Current Behavior

  • PDF files are successfully generated by the fortplot examples
  • The workflow copies files to doc/media/examples/
  • The workflow uploads ./build/doc to GitHub Pages
  • The make doc command doesn't properly copy media files from doc/media to build/doc/media
  • All PDF URLs return 404 errors

Expected Behavior

PDF files should be:

  1. Copied from doc/media/examples/ to build/doc/media/examples/ during the build
  2. Accessible at their GitHub Pages URLs

Example

The following URL returns 404:
https://lazy-fortran.github.io/fortplot/media/examples/scale_examples/log_scale.pdf

Root Cause

The build process has a disconnect between where files are placed (doc/media/) and where they need to be for deployment (build/doc/media/).

Impact

All PDF download links in the documentation are broken, preventing users from accessing the generated plot examples.

Suggested Fix

The make doc command or the GitHub workflow needs to ensure that media files are properly copied from doc/media/ to build/doc/media/ before deployment.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions