-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation
Description
Bug Description
PDF files are generated correctly during the documentation build but are not accessible at their GitHub Pages URLs, resulting in 404 errors for all PDF download links.
Current Behavior
- PDF files are successfully generated by the fortplot examples
- The workflow copies files to
doc/media/examples/ - The workflow uploads
./build/docto GitHub Pages - The
make doccommand doesn't properly copy media files fromdoc/mediatobuild/doc/media - All PDF URLs return 404 errors
Expected Behavior
PDF files should be:
- Copied from
doc/media/examples/tobuild/doc/media/examples/during the build - Accessible at their GitHub Pages URLs
Example
The following URL returns 404:
https://lazy-fortran.github.io/fortplot/media/examples/scale_examples/log_scale.pdf
Root Cause
The build process has a disconnect between where files are placed (doc/media/) and where they need to be for deployment (build/doc/media/).
Impact
All PDF download links in the documentation are broken, preventing users from accessing the generated plot examples.
Suggested Fix
The make doc command or the GitHub workflow needs to ensure that media files are properly copied from doc/media/ to build/doc/media/ before deployment.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentation