Skip to content

Conversation

@krystophny
Copy link
Collaborator

@krystophny krystophny commented Sep 19, 2025

Summary

  • Mark get_log_level() as pure since it reads a module variable without side effects.
  • Clarifies intent, enables compiler optimizations, and aligns with project guidance to prefer purity when applicable.

Verification
Commands run locally:

  • make test-ci
    • CI essential suite completed successfully
  • make test
    • ALL TESTS PASSED (fpm test)
  • make verify-artifacts
    • Artifact verification passed (no plot/text regressions)

Key excerpts:

  • CI essential: "CI essential test suite completed successfully"
  • Full suite: "ALL TESTS PASSED (fpm test)"
  • Artifacts: strict checks on PDFs/PNGs/txt passed

No artifact/output differences, as expected (signature-only attribute change).

Housekeeping

  • Wrapped two long lines in src/external/fortplot_logging.f90 to comply with the 88–90 column limit (no functional changes).

@krystophny krystophny merged commit b728c51 into main Sep 19, 2025
2 checks passed
@krystophny krystophny deleted the fix/issue-1347-mark-get-log-level-pure branch September 19, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants