Skip to content

fix: PDF files not deployed to GitHub Pages #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2025
Merged

fix: PDF files not deployed to GitHub Pages #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e96ff43
plan: add documentation bug issues to BACKLOG.md
krystophny Aug 24, 2025
3543279
update: move issue #224 from TODO to DOING
krystophny Aug 24, 2025
29b3960
fix: move media file copying after FORD generation in make doc
krystophny Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions BACKLOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# Development Backlog

## TODO (Ordered by Priority)
- [ ] #224: PDF files not deployed to GitHub Pages (404 errors)

## DOING (Current Work)
- [x] #223: ASCII backend generates empty plots (only frames/borders) (branch: fix/ascii-empty-plots-223)
- [x] #224: PDF files not deployed to GitHub Pages (404 errors) (branch: fix/pdf-deployment-224)

## DONE (Completed)
- [x] #223: ASCII backend generates empty plots (only frames/borders)
- [x] #220: Fix ASCII backend generating PDF binary content instead of text output
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ run-release:

# Build documentation with FORD
doc:
# Copy example media files to doc build directory BEFORE running FORD for proper linking
# Run FORD first to generate documentation structure
ford README.md
# Copy example media files to doc build directory AFTER running FORD
mkdir -p build/doc/media/examples
# Copy from doc/media if it exists (GitHub Actions workflow populates this)
if [ -d doc/media/examples ]; then cp -r doc/media/examples/* build/doc/media/examples/ 2>/dev/null || true; fi
Expand All @@ -105,8 +107,6 @@ doc:
cp "$$dir"*.mp4 "build/doc/media/examples/$$example_name/" 2>/dev/null || true; \
fi; \
done
# Now run FORD after media files are in place
ford README.md

# Generate coverage report
coverage:
Expand Down
Loading