fix: add robust RGB validation to prevent PDF color crashes #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive validation to pdf_write_color subroutine to handle invalid RGB values (NaN, infinity, out-of-range) gracefully. This prevents 'End of record' crashes when color mapping produces invalid values in contour plots. - Use IEEE_ARITHMETIC intrinsic for NaN/infinity detection - Clamp RGB values to valid [0.0, 1.0] range - Default invalid values to black (0.0) for safety - Fixes colored_contours example crash blocking GitHub Pages Fixes #317
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
krystophny
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing
Impact
This fix restores the GitHub Pages visual showcase functionality by allowing the colored_contours example to complete successfully. The validation ensures robust handling of edge cases in color mapping algorithms.
Fixes #317