fix: center PNG titles over plot area instead of data coordinates #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix PNG title positioning to match matplotlib behavior - Titles now center over plot area regardless of data coordinate range - Add render_title_centered() function for proper plot-area-relative positioning - Replace data-coordinate-based centering with pixel-based centering - Add comprehensive regression tests for title positioning - Resolves issue where titles appeared off-center with asymmetric data ranges Fixes #337 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
PNG titles were positioned using data coordinates
(x_min + x_max) / 2.0, which caused titles to appear off-center when data ranges were asymmetric or extreme. This did not match matplotlib's behavior where titles are always visually centered over the plot area.Solution
render_title_centered()function that calculates title position directly in pixel coordinatesplot_area%left + plot_area%width / 2(plot area center)plot_area%bottom - 30(30 pixels above plot area)Test Plan
test_png_title_positioning.f90demonstrating the issue with different data rangestest_title_centering_fix.f90as regression test for consistent positioningBefore/After
Before: Title position varied based on data coordinate range, appearing off-center with asymmetric data
After: Title consistently centered over plot area regardless of data coordinates, matching matplotlib behavior
Fixes #337
🤖 Generated with Claude Code