refactor: extract label positioning constants to shared module #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add XLABEL_VERTICAL_OFFSET, YLABEL_HORIZONTAL_OFFSET, TICK_MARK_LENGTH to fortplot_constants.f90 - Replace hardcoded values (30, 10, 5 pixels) in fortplot_raster.f90 with named constants - Export new constants through main fortplot.f90 module for public API access - Improves maintainability by centralizing positioning configuration - All targeted tests pass, examples compile and run successfully fixes #343
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
krystophny
deleted the
refactor-extract-label-positioning-constants-343
branch
krystophny
added a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fortplot_constants.f90fortplot_raster.f90fortplot.f90module for public API accessChanges Made
New Constants Added to
fortplot_constants.f90:XLABEL_VERTICAL_OFFSET = 30- X-axis label vertical offset below plot areaYLABEL_HORIZONTAL_OFFSET = 10- Y-axis label horizontal offset from left edgeTICK_MARK_LENGTH = 5- Tick mark length extending from axis linesFiles Modified:
/src/fortplot_constants.f90- Added label positioning constants with documentation/src/fortplot_raster.f90- Replaced hardcoded values with named constants/src/fortplot.f90- Export new constants for public API accessTesting
test_label_positioning,test_raster_ylabel) passBenefits
This refactoring addresses the technical debt identified in issue #343 during code review of PR #341.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com