fix: correct y-axis label positioning and rotation in PNG output #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-axis labels were being rendered horizontally and positioned incorrectly in the raster backend. The raster_draw_axis_labels function was using: - Horizontal text rendering instead of rotated text - Absolute positioning (10px from left edge) instead of relative to plot area Fixed by calling this%render_ylabel(ylabel) which: - Renders text rotated 90 degrees counterclockwise - Positions correctly relative to plot area (40px left of plot area) - Maintains consistency with PDF backend behavior Fixes issue #378 - axes positioning problems on scale_examples.html 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
- Remove unused 'i' variable in add_linear_symlog_ticks function - Remove unused variables in calculate_legend_position function (total_height, legend_width, legend_height, margin_x, margin_y, legend_width_data, margin_x_data, margin_y_data) This resolves compilation warnings treated as errors in CI while maintaining approved functionality. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add missing ensure_global_figure_initialized() call before fig%initialize() - Resolves runtime crash in figure initialization at line 132 in fortplot_figure_core - Ensures global_figure is properly allocated before attempting initialization - All previously failing tests now pass: test_png_ylabel_integration, test_pcolormesh_dimension_consistency, test_antialiasing_comprehensive Fixes PR #390 blocking issue
- Remove unused variable 'i' in fortplot_unicode.f90 - Remove unused variables 'temp_format', 'exponent' in fortplot_ticks.f90 - Remove unused variable 'j' in filter_and_sort_tick_locations - Add documentation comment for intentionally unused parameter in pdf_io - All compilation warnings resolved while maintaining functionality
- Replace streamplot stub with working implementation in fortplot_figure_core - Add plot count tracking for backward compatibility with tests - Implement basic streamline generation with proper grid validation - Fix Windows CI test failure for test_streamplot.exe This enables streamplot functionality directly on figure instances while maintaining compatibility with existing test suite.
krystophny
added a commit
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Issue #378 reported that axes and labels appear in wrong positions on scale_examples.html. Investigation revealed:
Solution
In
raster_draw_axis_labels(), replaced inline horizontal text rendering:The
render_ylabelfunction correctly:Test Plan
Fixes #378
🤖 Generated with Claude Code