Use make_unique for unique_ptr construction#2579
Merged
lballabio merged 2 commits intoMay 19, 2026
Merged
Conversation
|
coverage: 74.621% (+0.05%) from 74.573% — jewonj0620:feature/use-make-unique-ptr into lballabio:master |
lballabio
reviewed
May 15, 2026
| { | ||
| Real ss=0.0; | ||
| std::unique_ptr<double[]> xiv(new double[2048*2048+1]); | ||
| std::unique_ptr<double[]> xiv = std::make_unique<double[]>(2048*2048+1); |
Owner
There was a problem hiding this comment.
While we're modernizing I'd use auto for all these declarations.
Contributor
Author
There was a problem hiding this comment.
Thanks. I changed the declarations to use auto in the files I modified first.
There are many other places that need to be updated to follow modern C++ practices. I will address them in several follow-up commits after this.
\
lballabio
changed the title
make_unique for unique_ptr construction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanically replace raw
new-basedstd::unique_ptrconstruction andreset(new ...)withstd::make_unique.