Skip to content

Mandarin support add update#555

Merged
lbedner merged 2 commits intomainfrom
mandarin-support-add-update
Mar 22, 2026
Merged

Mandarin support add update#555
lbedner merged 2 commits intomainfrom
mandarin-support-add-update

Conversation

@lbedner
Copy link
Copy Markdown
Owner

@lbedner lbedner commented Mar 22, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 22, 2026 03:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands i18n coverage (including Mandarin/Chinese translations) across multiple CLI commands and core validators, and reduces hard-coded English output during update/deploy flows.

Changes:

  • Added many new locale strings (EN + ZH) for add/remove service, components/services listing, update, ingress, deploy, and validation messages.
  • Updated CLI commands and core validators to use t(...) instead of hard-coded English strings.
  • Adjusted update/deploy behavior to reduce English output (e.g., copier.run_copy(..., quiet=True) and moved server setup verification output into the CLI).

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
aegis/templates/copier-aegis-project/{{ project_slug }}/scripts/server-setup.sh.jinja Removed end-of-script verification/next-steps output from the generated server setup script.
aegis/i18n/locales/zh.py Added substantial new ZH translations for many CLI commands and validation messages.
aegis/i18n/locales/en.py Added substantial new EN strings for newly i18n’d commands and deploy/update flows.
aegis/core/services.py Localized unknown-service validation errors.
aegis/core/service_resolver.py Localized unknown-service validation errors.
aegis/core/dependency_resolver.py Localized unknown-component validation errors.
aegis/core/copier_updater.py Localized update output and suppressed Copier’s default English output.
aegis/commands/version.py Localized version output.
aegis/commands/update.py Localized most update command output and improved structured messaging.
aegis/commands/services.py Localized services listing headers and dependency labels; added translated descriptions with fallback.
aegis/commands/remove_service.py Localized remove-service UX and added translated descriptions with fallback.
aegis/commands/ingress.py Localized ingress-enable UX and file operation messages.
aegis/commands/deploy.py Localized deploy UX and added post-setup verification output using translation keys.
aegis/commands/components.py Localized components listing and dependency labels; added translated descriptions with fallback.
aegis/commands/add_service.py Localized add-service UX, warnings, and migration/setup guidance; added translated descriptions with fallback.
aegis/commands/add.py Preserved typer.Exit while localizing validation failure path.
aegis/cli/callbacks.py Localized unknown-services validation message.
Comments suppressed due to low confidence (1)

aegis/templates/copier-aegis-project/{{ project_slug }}/scripts/server-setup.sh.jinja:1

  • The server setup script no longer prints any completion/verification/next-steps output (the entire section was removed), leaving only a blank line. If this script is ever executed directly (outside aegis deploy-setup), users will get almost no confirmation that setup succeeded or what to do next. Consider restoring a minimal, language-agnostic completion message (or at least a short note pointing users to the CLI for verification), even if the detailed verification has moved into the Python deploy-setup command.
{%- if include_ingress -%}

Comment thread aegis/commands/ingress.py Outdated
Comment thread aegis/commands/deploy.py
Comment thread aegis/core/copier_updater.py Outdated
Comment thread aegis/commands/add_service.py
@lbedner lbedner force-pushed the mandarin-support-add-update branch from e5e0446 to fa9d417 Compare March 22, 2026 03:07
@lbedner lbedner force-pushed the mandarin-support-add-update branch from fa9d417 to 10added Compare March 22, 2026 03:09
@lbedner lbedner merged commit 8f43a3b into main Mar 22, 2026
7 checks passed
@lbedner lbedner deleted the mandarin-support-add-update branch March 22, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants