Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands i18n coverage (including Mandarin/Chinese translations) across multiple CLI commands and core validators, and reduces hard-coded English output during update/deploy flows.
Changes:
- Added many new locale strings (EN + ZH) for add/remove service, components/services listing, update, ingress, deploy, and validation messages.
- Updated CLI commands and core validators to use
t(...)instead of hard-coded English strings. - Adjusted update/deploy behavior to reduce English output (e.g.,
copier.run_copy(..., quiet=True)and moved server setup verification output into the CLI).
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| aegis/templates/copier-aegis-project/{{ project_slug }}/scripts/server-setup.sh.jinja | Removed end-of-script verification/next-steps output from the generated server setup script. |
| aegis/i18n/locales/zh.py | Added substantial new ZH translations for many CLI commands and validation messages. |
| aegis/i18n/locales/en.py | Added substantial new EN strings for newly i18n’d commands and deploy/update flows. |
| aegis/core/services.py | Localized unknown-service validation errors. |
| aegis/core/service_resolver.py | Localized unknown-service validation errors. |
| aegis/core/dependency_resolver.py | Localized unknown-component validation errors. |
| aegis/core/copier_updater.py | Localized update output and suppressed Copier’s default English output. |
| aegis/commands/version.py | Localized version output. |
| aegis/commands/update.py | Localized most update command output and improved structured messaging. |
| aegis/commands/services.py | Localized services listing headers and dependency labels; added translated descriptions with fallback. |
| aegis/commands/remove_service.py | Localized remove-service UX and added translated descriptions with fallback. |
| aegis/commands/ingress.py | Localized ingress-enable UX and file operation messages. |
| aegis/commands/deploy.py | Localized deploy UX and added post-setup verification output using translation keys. |
| aegis/commands/components.py | Localized components listing and dependency labels; added translated descriptions with fallback. |
| aegis/commands/add_service.py | Localized add-service UX, warnings, and migration/setup guidance; added translated descriptions with fallback. |
| aegis/commands/add.py | Preserved typer.Exit while localizing validation failure path. |
| aegis/cli/callbacks.py | Localized unknown-services validation message. |
Comments suppressed due to low confidence (1)
aegis/templates/copier-aegis-project/{{ project_slug }}/scripts/server-setup.sh.jinja:1
- The server setup script no longer prints any completion/verification/next-steps output (the entire section was removed), leaving only a blank line. If this script is ever executed directly (outside
aegis deploy-setup), users will get almost no confirmation that setup succeeded or what to do next. Consider restoring a minimal, language-agnostic completion message (or at least a short note pointing users to the CLI for verification), even if the detailed verification has moved into the Pythondeploy-setupcommand.
{%- if include_ingress -%}
e5e0446 to
fa9d417
Compare
fa9d417 to
10added
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.