Conversation
There was a problem hiding this comment.
Pull request overview
Introduces an R3 “plugin options” layer that moves bracket-syntax parsing (e.g. auth[org,postgres], ai[sqlite,openai]) into a generic, declarative OptionSpec model on PluginSpec, and uses those declarations to drive auto-required components during service resolution.
Changes:
- Add
aegis/core/option_spec.pywithOptionSpec/OptionMode, genericparse_options(), andcompute_auto_requires(). - Declare bracket-syntax options directly on service specs (
auth,ai,insights) and refactor the per-service parser modules into thin shims. - Update
ServiceResolverto apply spec-drivenauto_requiresand normalize bracketed component variants (e.g. preferdatabase[postgres]overdatabase), plus add focused tests for the generic option parser.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
aegis/core/option_spec.py |
New generic option declaration + parsing + auto-requires utilities for bracket syntax. |
aegis/core/plugin_spec.py |
Adds PluginSpec.options to carry declarative bracket-syntax option specs. |
aegis/core/services.py |
Defines OptionSpec lists for auth/ai/insights service specs (incl. auto_requires). |
aegis/core/service_resolver.py |
Replaces per-service auto-requires logic with spec-driven auto-requires and variant normalization. |
aegis/core/ai_service_parser.py |
Converts AI parser into a back-compat shim around the generic parser. |
aegis/core/auth_service_parser.py |
Converts auth parser into a back-compat shim around the generic parser. |
aegis/core/insights_service_parser.py |
Converts insights parser into a back-compat shim around the generic parser. |
aegis/core/components.py |
Doc update clarifying why kw_only=True is required for the ComponentSpec alias. |
tests/core/test_option_spec.py |
New unit tests locking in the generic option parser contract. |
tests/core/test_insights_service_parser.py |
Updates assertions to match the new generic error wording. |
c861334 to
908eba1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.