Conversation
5d49002 to
53a7dc7
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the plugin system to support plugin-shipped template trees and expands “_plugins”-driven wiring/parity across core project templates (deps, dashboard widgets, settings mixins, pyproject deps, docker-compose services). It also updates service specs/templates to support a per-service deps.py refactor and adds test fixtures + parity/integration tests to lock behavior.
Changes:
- Add plugin template discovery (
plugin_template_resolver) and end-to-end install/render support inManualUpdater. - Expand shared templates to emit plugin-provided wiring (deps providers, dashboard cards/modals, settings mixins), plus plugin packaging metadata (pyproject deps, docker-compose services).
- Add/extend tests and fixtures to validate template resolution, plugin tree installation, and legacy-vs-plugin render parity.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| aegis/core/plugin_template_resolver.py | New resolver to locate <plugin>/templates/ for plugin-shipped template trees. |
| aegis/core/manual_updater.py | Add install_plugin_template_tree() to render a plugin’s .jinja files into a project. |
| aegis/core/plugin_composer.py | Serialize plugin pyproject_deps and docker_services into _plugins answers. |
| aegis/core/services.py | Extend service wiring (deps providers, modal/card ids) and align auth deps with bcrypt + pyproject deps parity. |
| aegis/templates/.../app/components/backend/api/deps.py.jinja | Move per-service FastAPI dependency providers into per-service app/services/<svc>/deps.py and import providers; add plugin deps-provider loop. |
| aegis/templates/.../app/services/auth/deps.py.jinja | Add per-service dependency providers for auth (and org-scoped providers). |
| aegis/templates/.../app/services/insights/deps.py.jinja | Add per-service dependency providers for insights. |
| aegis/templates/.../app/services/payment/deps.py.jinja | Add per-service dependency provider for payment. |
| aegis/templates/.../app/core/config.py.jinja | Support plugin settings mixins via _plugins[].wiring.settings_mixins. |
| aegis/templates/.../pyproject.toml.jinja | Emit plugin-provided dependencies from _plugins[].pyproject_deps. |
| aegis/templates/.../docker-compose.yml.jinja | Emit plugin-provided docker services from _plugins[].docker_services. |
| aegis/templates/.../app/components/backend/startup/component_health.py.jinja | Register plugin-provided health checks from _plugins[].wiring.health_checks. |
| aegis/templates/.../app/components/frontend/main.py.jinja | Import and render plugin dashboard cards; extend service-card handling. |
| aegis/templates/.../app/components/frontend/dashboard/cards/init.py.jinja | Add plugin card imports and align in-tree imports to absolute paths for parity. |
| aegis/templates/.../app/components/frontend/dashboard/modals/init.py.jinja | Add plugin modal imports and align in-tree imports to absolute paths for parity. |
| aegis/templates/.../app/components/frontend/dashboard/cards/card_utils.py.jinja | Switch modal imports to absolute paths and add plugin modal map entries. |
| tests/core/test_plugin_template_resolver.py | New tests for resolving plugin template roots. |
| tests/core/test_manual_updater_plugins.py | New integration test for installing/rendering plugin template trees into a project. |
| tests/core/test_plugin_render_parity.py | Add parity tests for deps.py, dashboard init modules, pyproject deps, and card_utils wiring. |
| tests/core/test_services.py | Update auth deps assertion to expect bcrypt instead of passlib. |
| tests/fixtures/aegis_plugin_test/** | Add a fake plugin package with a minimal templates/{{ project_slug }} tree for round-8 tests. |
57219b4 to
16c3c35
Compare
16c3c35 to
97f1bdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.