Feature/fvgp 4.8#51
Merged
Merged
Conversation
Bump the fvgp pin to ~=4.8.1 and adapt to its breaking API changes: - rename constructor args gp2Scale_dask_client->dask_client and gp2Scale_linalg_mode->linalg_mode; store them privately to avoid fvgp 4.8's new read-only `dask_client` property - remove calc_inv (folded into linalg_mode="CholInv"/"Inv" upstream) - rename update_gp_data/tell kwarg gp_rank_n_update->rank_n_update - update test_gpCAM for renamed fvgp internals (marginal_density-> marginal_likelihood, .KVlinalg->.kv) Sync GPOptimizer/fvGPOptimizer docstrings with fvgp 4.8.1 GP/fvGP (keeping cost_function/logging and optional x_data/y_data), surface new fvgp 4.8 features (validation metrics, bump/sle_kernel, new linalg_mode values) in the API docs, and drop the duplicate-autodoc fvgp_* attribute entries. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Extend test_pickle with value-level round-trip checks of the gpcam config attributes (cost_function, _gp2Scale, gp2Scale_batch_size, _linalg_mode, ram_economy, _args, logging, multi_task, x_out, gp) and an fvGPOptimizer round-trip exercising multi_task=True and x_out. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 87.52% 87.59% +0.07%
==========================================
Files 9 9
Lines 617 637 +20
==========================================
+ Hits 540 558 +18
- Misses 77 79 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.