Load profiles

[wafschneider]

With these changes to config-dev.js and bib.dev.js, profiles can be read from the Verso config store.

[kirkhess]

What is package-lock.json?

In the config, I would remove var versoURL, and have these constants:
"url" : "http://mlvlp04.loc.gov:3000",
"profileFilter": " /verso/api/configs?filter[where][configType]=profile&filter[where][name]=/"
then
"profiles":[
url+ profileFilter + "BIBFRAME 2.0 Agents.json"

I don't know how to do this as part of a pull...

[wafschneider]

package-lock.json is an npm lock file that locks in dependencies for a reproducible build (https://docs.npmjs.com/files/package-lock.json). A developer ca]n always remove it and rebuild in order to test against newer versions of the dependencies. It's actually probably not strictly necessary for the bfe, except in the case where you are running standalone outside of recto.

To make a change to a PR, you can check out the branch, make your change, commit, and push it back to the branch. The new commit will become a part of the PR.

That said, I don't think what you're suggesting will work, as url and profileFilter (in your example) are properties of the config object, not constants, so you can't refer to them in that way. You could do something like this:

var url = "http://localhost:3000";
var profileFilter = "/verso/api/configs?filter[where][configType]=profile&filter[where][name]=";
var config = {
  "url": url,
  [...]
  "profiles": [
    url + profileFilter + "BIBFRAME 2.0 Admin Metadata",
    [...]
  ]
};

If you think that is clearer, let me know and I will make the change.

[kirkhess]

Just leave it for now - I can do that later. - Kirk

On Mon, Jun 25, 2018 at 5:25 PM Wayne Schneider ***@***.***> wrote: package-lock.json is an npm lock file that locks in dependencies for a reproducible build (https://docs.npmjs.com/files/package-lock.json). A developer ca]n always remove it and rebuild in order to test against newer versions of the dependencies. It's actually probably not strictly necessary for the bfe, except in the case where you are running standalone outside of recto. To make a change to a PR, you can check out the branch, make your change, commit, and push it back to the branch. The new commit will become a part of the PR. That said, I don't think what you're suggesting will work, as url and profileFilter (in your example) are properties of the config object, not constants, so you can't refer to them in that way. You could do something like this: var url = "http://localhost:3000";var profileFilter = "/verso/api/configs?filter[where][configType]=profile&filter[where][name]=";var config = { "url": url, [...] "profiles": [ url + profileFilter + "BIBFRAME 2.0 Admin Metadata", [...] ] }; If you think that is clearer, let me know and I will make the change. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABWqks5yY82OM8XR8qVf8pUZpilzqzTHks5uAVVcgaJpZM4U0em7> .

-- - Kirk