Conversation
Collaborator
|
I double checked any line with % in the R2S section of the Arabic YML. All percent signs were in the correct position (on left for tokens at end, and on right for initial tokens). NOTE: the lines of code are in Latin script which is read left to right even though Arabic displays right to left.Randy Barry - ᠷᠧᠨᠳᠢ ***@***.***>On Mar 29, 2025, at 00:27, Stefano Cossu ***@***.***> wrote:
@scossu requested your review on: #206 Update Arabic r2s..
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
thisismattmiller
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From @RandyBarry 's provided file.
Please double check as this has been merged selectively, because Randy's file had the old-style truncation character positioning.