Conversation
Member
|
Just to be clear this issue is assigned to us, is it supposed to be review requested, or is there something we need to work on? |
thisismattmiller
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on a very small data set, but the nasalization rules seem to be applied correctly.
The only inconvenience of the hierarchical approach is that hooks are not yet inheritable (I gave it a try but the logic is more complex than I want to tackle at the moment), therefore the nasalization hook must be added to all the languages that need such rules applied.
This PR also slightly alters the transliteration flow in that it adds a new
ctx.origmember, which is now the read-only original source.ctx.srcbecomes read-write, so there is no need for hacky assignments toctx._src.