fix test of system clock using default timezone#32
Merged
lcobucci merged 1 commit intolcobucci:masterfrom Apr 26, 2020
slepic:system-clock-test-use-default-timezone
Merged
fix test of system clock using default timezone#32lcobucci merged 1 commit intolcobucci:masterfrom slepic:system-clock-test-use-default-timezone
lcobucci merged 1 commit intolcobucci:masterfrom
slepic:system-clock-test-use-default-timezone
Conversation
lcobucci
approved these changes
Apr 26, 2020
Owner
lcobucci
left a comment
lcobucci
left a comment
There was a problem hiding this comment.
This makes sense! Thanks for your contribution 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, me again:)
I just noticed that the test for SystemClock is written so that it relies that the machine running the test has UTC as default. Probably would be better to use the actual system default...