add strict type checking for tuple #452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
reviewed
May 6, 2022
src/libasr/asr_utils.h
Outdated
| case ASR::ttypeType::Tuple: { | ||
| return "tuple"; | ||
| ASR::Tuple_t *t = (ASR::Tuple_t *)t; | ||
| return "tuple[" + type_to_str_python(t->m_type) + "]"; |
Contributor
There was a problem hiding this comment.
The issue is here. The t->m_type is a list of types (pointer to pointer), and there is t->n_type terms (I think). So just loop over them, and print it like tuple[i32, f64, str, ...].
Contributor
Author
There was a problem hiding this comment.
thanks for the review, I will try to make changes to it.
Collaborator
There was a problem hiding this comment.
Yup, do something similar to this:
lpython/src/libasr/asr_utils.cpp
Lines 58 to 59 in ef633f2
replace
dependencies with type and use the std::string variable to store all the type's information...
Contributor
|
Otherwise this looks good, I think that is how it should be done. Thanks for working on it. |
tests/errors/test_tuple1.py
Outdated
| t: tuple[i32, str] | ||
| t = (1, 2) | ||
|
|
||
| main() No newline at end of file |
Collaborator
There was a problem hiding this comment.
Suggested change
| main() | |
| main() | |
tests/tests.toml
Outdated
|
|
||
| [[test]] | ||
| filename = "errors/test_tuple1.py" | ||
| asr = true |
Collaborator
There was a problem hiding this comment.
Suggested change
| asr = true | |
| asr = true | |
Merged
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433