Conversation
🤖 Augment PR SummarySummary: This PR tweaks the browser extension UI to make development vs production easier to distinguish and simplifies preview title rendering. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| @@ -1,4 +1,5 @@ | |||
| import {log} from "./logger"; | |||
| import {isDebugging} from "./env"; | |||
There was a problem hiding this comment.
isDebugging ultimately depends on process.env.NODE_ENV (see env.ts); if the webpack define replacement ever isn’t applied (or a process shim isn’t present), importing this could throw process is not defined and break the background script at startup. Consider double-checking that your extension build always inlines NODE_ENV for both dev/prod builds.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
主要变更
[DEV]标识,以方便在开发时与生产环境区分。ArticlePreview组件中的标题渲染逻辑,并移除了不再需要的isXTwitterSite辅助函数。