fix: handle XHR responseType='json' when accessing response data#121
Merged
lcomplete merged 1 commit intolcomplete:devfrom Mar 14, 2026
Merged
fix: handle XHR responseType='json' when accessing response data#121lcomplete merged 1 commit intolcomplete:devfrom
lcomplete merged 1 commit intolcomplete:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix XHR response interceptor to handle
responseType='json'correctly on Android browsers.Problem
The extension fails to capture Twitter/X.com content on Android browsers (e.g., Lemur Browser).
Root cause: When
XMLHttpRequest.responseTypeis set to'json', accessing theresponseTextproperty throws aDOMException:DOMException: Failed to read the 'responseText' property from 'XMLHttpRequest':
The value is only accessible if the object's 'responseType' is '' or 'text' (was 'json').
This is per MDN
specification:
Reproduction Steps
Solution
Handle
responseType='json'case by using theresponseproperty instead ofresponseText: