Urgent patch to rotate_given_surface_normal #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code from default input options.
Fix readme
[WIP] Add byexample workflow for doctesting README.md This adds automatic tests of the code snippets in the readme. Currently this only covers the examples, and not the installation section - there are some difficulties with configuring byexample to handle the much more complicated output of those sections, and all of the content therein is already being run as part of the github workflows anyway. What this will do is prevent changes to the examples from making the README outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotate given surface normal calculates rotations incorrectly for near-parallel incidence; I've made a change to the threshold for screening out such cases, but a more reliable fix is probably in order.