Improve handler descriptions to show WHY commands are blocked#23
Merged
Improve handler descriptions to show WHY commands are blocked#23
Conversation
Handlers now include the triggering flag/action in their description: - curl: shows -d, --json, POST, DELETE, --mail-from, etc. - tar: shows create, extract, append, update, delete - awk: shows system(), redirect, pipe - wget: shows download Added test_descriptions.py to verify description quality.
Add action context to ask descriptions (e.g., "pytest run" instead of "pytest", "xargs --interactive" instead of "xargs").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handler descriptions now show the specific flag or action that triggered the confirmation prompt, making it clearer to users WHY a command needs approval.
Changes
Before:
After:
Modified Handlers
-d,--json,POST,DELETE,--mail-from, etc.)create,extract,append,update,delete)system(), redirects, pipes)Testing
Added
tests/cli/test_descriptions.pywith 138 test cases to verify description quality across all modified handlers.All tests pass across Python 3.11-3.14.