Fix split_pipeline bugs causing incorrect reasons#24
Merged
Conversation
Was passing `cmd` (leftover from previous pipeline iteration) instead of `node`, causing commands after a pipeline to all report the last pipeline command. Also adds failing test for compound commands in pipelines.
For while/for/if/case loops, return the kind name instead of empty string so reasons display properly (e.g., "while" instead of "").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split_pipelineusingcmdinstead ofnodefor standalone commands, causing repeated reasons (e.g.,bash-oracle, bash-oracle, bash-oracle)_reconstruct_commandreturning empty string for compound commands (while,for,if), now returns kind name