fix(pipeline): fix race condition in tee that skips quads for slow consumers#336
Merged
fix(pipeline): fix race condition in tee that skips quads for slow consumers#336
Conversation
…nsumers - The shared `consumed` counter let a fast writer (e.g. FileWriter) lap a slow writer (e.g. SparqlUpdateWriter), causing the slow writer to skip items - Replace shared counter with per-branch consumption tracking and a barrier: fast branches wait until all branches have consumed before advancing - Add test with differently-paced writers to cover the race condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tee()where a fast writer (e.g.FileWriter) could lap a slow writer (e.g.SparqlUpdateWriter), causing the slow writer to skip quadsconsumedcounter with no per-branch tracking – any branch could increment it, letting one branch advance the source past items another branch hadn't seen