fix(pipeline): propagate Last-Modified from probe to candidate distribution#365
Merged
Merged
Conversation
…bution Closes #296. `ImportResolver.importDataset()` now copies the HTTP `Last-Modified` header captured during probing onto candidate distributions before passing them to the importer. This lets `LastModifiedDownloader` skip redundant downloads (and preserves the QLever index cache) for distributions that don't have `lastModified` set by the dataset source – e.g. manual `dataset.ttl` selections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296.
Summary
ImportResolver.importDataset()now copies the HTTPLast-Modifiedheader captured during probing (ProbeResult.lastModified) onto candidate distributions before passing them to the importer. This letsLastModifiedDownloader.localFileIsUpToDate()skip redundant downloads – and preserves the QLever index cache – for distributions that don’t havelastModifiedset by the dataset source (e.g. manualdataset.ttlselections).Existing
lastModifiedvalues (e.g. those set by@lde/dataset-registry-clientfrom the registry’smodifiedfield) are preserved.Test plan
Last-Modifiedpropagation from probe to candidatelastModifiedis not overwritten by probe valuenpx nx test @lde/pipeline(213 tests pass)