Set default roles in new resolver #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeatureSchema: remove checks that explicitly set PRIMARY_GEOMETRY, PRIMARY_INSTANT, PRIMARY_INTERVAL_START, and PRIMARY_INTERVAL_END roles Closes ldproxy/ldproxy#1412
If no primary geometry is explicitly set, the first spatial property is assigned this role. If no primary instant or interval is explicitly set, the first temporal property is assigned this role. These defaults are explicitly set in the hydration step. This has to be done after the schema is complete. The new DefaultRolesResolver is executed as the final resolver. Note that other roles including the primary interval start or end are only applied, if explicitly set in the provider schema.
Contributor
Author
|
@azahnen - I have added the new resolver, the PR should be ready for your review. I have also updated the first comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the checks in FeatureSchema that explicitly set PRIMARY_GEOMETRY, PRIMARY_INSTANT, PRIMARY_INTERVAL_START, and PRIMARY_INTERVAL_END roles.
Instead a new TypesResolver (DefaultRolesResolver) is executed as the final step during hydration of the SQL/Oracle providers. If no primary geometry is explicitly set, the first spatial property is assigned this role. If no primary instant or interval is explicitly set, the first temporal property is assigned this role.
Note that other roles including the primary interval start or end are only applied, if explicitly set in the provider schema.
Closes ldproxy/ldproxy#1412