Skip to content

Fix for possibly Arabic digits and other weird player filename combos.#832

Merged
Raycoms merged 2 commits into
version/mainfrom
fix/bad-filenames
May 19, 2026
Merged

Fix for possibly Arabic digits and other weird player filename combos.#832
Raycoms merged 2 commits into
version/mainfrom
fix/bad-filenames

Conversation

@uecasm
Copy link
Copy Markdown
Contributor

@uecasm uecasm commented May 16, 2026

Closes discord report

Changes proposed in this pull request

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please (should port)

Raycoms
Raycoms previously approved these changes May 17, 2026
Copy link
Copy Markdown
Contributor

@someaddons someaddons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure we wrap all calls that use the name for the folder, else some may break

@uecasm
Copy link
Copy Markdown
Contributor Author

uecasm commented May 19, 2026

Make sure we wrap all calls that use the name for the folder, else some may break

I did check everywhere that uses Minecraft.getInstance().getUser().getName(), and a more quick check for anything similar. As far as I know, I got everywhere. Let me know if I missed something.

@Raycoms Raycoms merged commit 9ea1528 into version/main May 19, 2026
5 checks passed
@Raycoms Raycoms deleted the fix/bad-filenames branch May 19, 2026 10:13
@Raycoms
Copy link
Copy Markdown
Contributor

Raycoms commented May 19, 2026

please port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants