[FIX] geoengine_tools: don't select measurement features#7
Merged
Conversation
Clicking a drawn ruler / area / proximity geometry crashed with "undefined is not an object (evaluating 'attributes.id')": measurement features live on a dedicated layer but carry no record, so the base select interaction selected them and updateInfoBox/mountGeoengineRecord dereferenced their missing `attributes`. - registerInteraction(): exclude the measurement layer from both select interactions via a `layers` filter. - updateInfoBox(): safety net — ignore features without `attributes`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Clicking a drawn measurement geometry (ruler, area, or proximity line) crashed:
Measurement features live on a dedicated layer and carry no record, so they have no
attributes. The baseol.interaction.Select(created without a layer filter) selected them, andupdateInfoBox/mountGeoengineRecordthen dereferenced the missingattributes.Fix (
geoengine_measure_tools.esm.js)registerInteraction(): exclude the measurement layer from both select interactions via alayersfilter (also removes the cosmetic “feature disappears on select” glitch).updateInfoBox(): safety net — ignore features withoutattributesso they never reachmountGeoengineRecord.Verified:
pre-commitprettier + eslint pass on the file.🤖 Generated with Claude Code