Selector functions implementation#706
Merged
robocoder merged 18 commits intoleafo:masterfrom Jun 4, 2019
Cerdic:dev/selector-functions
Merged
Selector functions implementation#706robocoder merged 18 commits intoleafo:masterfrom Cerdic:dev/selector-functions
robocoder merged 18 commits intoleafo:masterfrom
Cerdic:dev/selector-functions
Conversation
…selector-extend() as the logic is the same #310
Collaborator
|
ok; looking good |
Contributor
Author
|
And I think the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only
selector-unify()is missing in the #310 list, but this is not the easiest as the compiler have not yet any internal function doing this job.I pushed the PR so you can have a look, but I propose waiting it's complete to merge it.
The spec/test cases are taken from https://sass-lang.com/documentation/functions/selector with sometimes some addition for border cases