Skip to content

Conversation

@crosa7
Copy link
Contributor

@crosa7 crosa7 commented Oct 6, 2023

Description

Adjustment to make apache serve from the public directory instead of root folder

@crosa7 crosa7 requested a review from mychidarko October 6, 2023 09:25
Copy link
Member

@mychidarko mychidarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also try to serve from the public directory even in non-mvc projects. Can this be made into a different docker theme, so we have one for base projects and the other for Leaf MVC and Leaf API

@crosa7
Copy link
Contributor Author

crosa7 commented Oct 6, 2023

This will also try to serve from the public directory even in non-mvc projects. Can this be made into a different docker theme, so we have one for base projects and the other for Leaf MVC and Leaf API

Good point! Did not think of this. Will do that, thanks for the feedback!

@crosa7 crosa7 force-pushed the fix-serve-from-public-directory branch from 506ac61 to 430c8e2 Compare October 6, 2023 10:49
@crosa7
Copy link
Contributor Author

crosa7 commented Oct 6, 2023

This will also try to serve from the public directory even in non-mvc projects. Can this be made into a different docker theme, so we have one for base projects and the other for Leaf MVC and Leaf API

Changed thanks!

@crosa7 crosa7 requested a review from mychidarko October 6, 2023 10:50
@crosa7 crosa7 force-pushed the fix-serve-from-public-directory branch from 430c8e2 to 072adef Compare October 6, 2023 11:54
@crosa7 crosa7 requested a review from mychidarko October 6, 2023 11:54
@mychidarko
Copy link
Member

Awesome, thanks

@mychidarko mychidarko merged commit a127544 into v2.x Oct 6, 2023
@crosa7 crosa7 deleted the fix-serve-from-public-directory branch October 6, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants