Encoding via rejection sampling#38
Merged
tcoratger merged 15 commits intoleanEthereum:mainfrom Mar 16, 2026
Merged
Conversation
b-wagn
reviewed
Mar 10, 2026
Contributor
b-wagn
left a comment
b-wagn
left a comment
There was a problem hiding this comment.
Thanks for the PR! This is great :) Left some comments.
b-wagn
approved these changes
Mar 12, 2026
Contributor
b-wagn
left a comment
b-wagn
left a comment
There was a problem hiding this comment.
I am happy with it :) thanks a lot! maybe @tcoratger can have a very quick look before we merge
tcoratger
approved these changes
Mar 16, 2026
Contributor
tcoratger
left a comment
tcoratger
left a comment
There was a problem hiding this comment.
Looks nice, just left a few super minor comments but not blockers for me, feel free to merge when you think this is ready.
Co-authored-by: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Co-authored-by: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Co-authored-by: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: implem section 6.1 from borting Random Oracles: How to Build them, How to Use them
Still some work remaing to define nice instanciations (i.e. fixing the parameters), but maybe this can be done in a second PR?