Skip to content

fix: use SECONDS_PER_SLOT when deriving slots from time #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcoratger merged 1 commit into from
Nov 6, 2025
Merged

fix: use SECONDS_PER_SLOT when deriving slots from time #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lean_spec/subspecs/forkchoice/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class method acts as a factory for creating a new Store instance.
anchor_checkpoint = Checkpoint(root=anchor_root, slot=anchor_slot)

return cls(
time=Uint64(anchor_slot * INTERVALS_PER_SLOT),
time=Uint64(anchor_slot * SECONDS_PER_SLOT),
config=state.config,
head=anchor_root,
safe_target=anchor_root,
Expand Down Expand Up @@ -168,7 +168,7 @@ def validate_attestation(self, signed_attestation: SignedAttestation) -> None:
assert target_block.slot == data.target.slot, "Target checkpoint slot mismatch"

# Validate attestation is not too far in the future
current_slot = Slot(self.time // INTERVALS_PER_SLOT)
current_slot = Slot(self.time // SECONDS_PER_SLOT)
assert data.slot <= Slot(current_slot + Slot(1)), "Attestation too far in future"

def on_attestation(
Expand Down Expand Up @@ -246,7 +246,7 @@ def on_attestation(
# contributing to fork choice weights.

# Ensure forkchoice is current before processing gossip
time_slots = self.time // INTERVALS_PER_SLOT
time_slots = self.time // SECONDS_PER_SLOT
assert attestation_slot <= time_slots, "Attestation from future slot"

# Update new attestations if this is latest from validator
Expand Down Expand Up @@ -630,7 +630,7 @@ def tick_interval(self, has_proposal: bool) -> "Store":
"""
# Advance time by one interval
store = self.model_copy(update={"time": self.time + Uint64(1)})
current_interval = store.time % INTERVALS_PER_SLOT
current_interval = store.time % SECONDS_PER_SLOT % INTERVALS_PER_SLOT

if current_interval == Uint64(0):
# Start of slot - process attestations if proposal exists
Expand Down
Loading