limit number of attestation data in blocks

[anshalshukla]

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

• Ran tox checks to avoid unnecessary CI fails:

  uvx tox

• Considered adding appropriate tests for the changes.
• Considered updating the online docs in the ./docs/ directory.

[tcoratger]

I guess a bunch of tests are failing because we have more than 8 attestations in those tests.

Where does the 8 come from? This looks super small and restrictive no?

[anshalshukla]

Where does the 8 come from? This looks super small and restrictive no?

It's random value, I've increased it to 16. I think this number roughly denotes the number of network fractions we have with the given justified slot, on a stable network where every validator is attesting every slot 16 should be more than enough but I'm to increasing this as well.

cc: @g11tech

[g11tech]

Where does the 8 come from? This looks super small and restrictive no?

It's random value, I've increased it to 16. I think this number roughly denotes the number of network fractions we have with the given justified slot, on a stable network where every validator is attesting every slot 16 should be more than enough but I'm to increasing this as well.

cc: @g11tech

increasing beyond 16 doesn't make sense, beacon consensus has it capped at 8, for the validity of the test suite we can have 16 for now, else we should target it 8 (and lets make an issue for this so that we dont forget this)

its best to make it a config.yaml value, which clients can pick and we can use 16 here for testcases and use 8 for our networks

[g11tech]

why 8? because if majority to the newwork agrees, it will have same attestation data (1) and other 7 are good enugh to pack previous slot votings which arrived late and/or branches

(its common that some 3-4% of validators get their attestations included a slot later than the next slot in which they are expected to be packed because of timing games) giving this number from my estimates of running a mainnet beacon node where block comes with delay 3-4% of times