Skip to content

test(discovery): improve transport.py coverage to 98% (#518)#545

Merged
tcoratger merged 1 commit intoleanEthereum:mainfrom
Smartdevs17:test/coverage-discovery-transport
Apr 9, 2026
Merged

test(discovery): improve transport.py coverage to 98% (#518)#545
tcoratger merged 1 commit intoleanEthereum:mainfrom
Smartdevs17:test/coverage-discovery-transport

Conversation

@Smartdevs17
Copy link
Copy Markdown
Contributor

@Smartdevs17 Smartdevs17 commented Apr 9, 2026

Summary

Improve coverage for src/lean_spec/subspecs/networking/discovery/transport.py from 71% to meet the 85%+ target.

What's covered

  • send_ping: Pong response handling, non-Pong response handling
  • send_talkreq: TalkResp response handling, non-TalkResp response handling
  • _send_multi_response_request: Deadline elapsed timeout, NODES response collection
  • _handle_whoareyou: Matching nonce path with handshake response
  • _handle_packet: MESSAGE flag routing
  • _build_message_packet: Session key path when session exists
  • _handle_handshake: Empty message bytes skipping decryption
  • _handle_message: Decryption failure with session present

Changes

  • test_transport.py: Added 9 new tests in TestSendPingNonPong, TestSendTalkReqNonTalkResp, TestSendMultiResponseRequest, TestHandleWhoareyou, TestHandlePacketRouting, TestBuildMessagePacketDummyKey, TestHandleHandshake, TestHandleMessageDecryption

Test Results

  • 78 tests passing (was 54)
  • 98% line coverage on transport.py
  • All quality checks pass (ruff, typecheck, codespell, mdformat)

Notes

Remaining uncovered items are pure branch-coverage paths (238->243, 244->243, 420->410, 629->628, 694->exit, 771-772) - minor paths that don't affect the 85%+ target.

Closes #518

/cc @tcoratger

@tcoratger tcoratger merged commit 7a9508a into leanEthereum:main Apr 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: improve coverage for discovery v5 UDP transport (71%)

2 participants