refactor: move generate_pre_state to consensus_testing package root#550
Merged
tcoratger merged 1 commit intoleanEthereum:mainfrom Apr 9, 2026
Conversation
The function was misplaced in test_types/, which is otherwise exclusively Pydantic model definitions. Move it to consensus_testing/genesis.py, alongside keys.py which it directly depends on. Also improves the function: - Replace assert with ValueError for input validation - Clean up docstring (remove default value restating) - Rename validator_list to validators Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_pre_statefromconsensus_testing/test_types/genesis.pytoconsensus_testing/genesis.py— thetest_types/package is exclusively Pydantic model definitions, and a factory function doesn't belong there. The new location sits alongsidekeys.py, its main dependency.assertwithValueErrorfor input validation —assertgets stripped bypython -Oand this validates caller input, not an internal invariant.validator_list→validators.No downstream changes needed — all callers import from
consensus_testingdirectly, so the public API is unchanged.Test plan
uvx tox -e all-checkspasses (ruff, ty, codespell, mdformat)uv run pytestconfirms no import breakageuv run fill --fork=devnet --clean -n autogenerates fixtures successfully🤖 Generated with Claude Code