test(st): genesis with maximum validators#641
Closed
akronim26 wants to merge 4 commits intoleanEthereum:mainfrom
Closed
test(st): genesis with maximum validators#641akronim26 wants to merge 4 commits intoleanEthereum:mainfrom
akronim26 wants to merge 4 commits intoleanEthereum:mainfrom
Conversation
akronim26
force-pushed
the
max-validators
branch
2 times, most recently
from
29d333a to
43839f2
Compare
Contributor
Author
|
Hey @tcoratger, I’m not sure how to test the two validator-related tests implemented in this PR. Locally, I used 4096 keys that I generated, but those aren’t available here. Should I push them, or would that unnecessarily bloat the repository? |
Collaborator
|
@akronim26 Hmm, the tests are already super long due to the large keys and long aggregation time, so maybe it's not a good idea to merge such a huge test right now which will have the effect of drastically increasing the duration of the CI which is almost 50 min already when merging on main. I'll leave this PR on hold until we find a better solution. |
Collaborator
|
Closing for now. |
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR introduces comprehensive stress tests for the consensus layer when configured with the maximum allowed validator set (VALIDATOR_REGISTRY_LIMIT = 4096).
🔗 Related Issues or PRs
Fixes #580
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox