refactor(tests): move state and forkchoice tests under forks/lstar (Stage 6 of #686)#706
Merged
tcoratger merged 1 commit intoleanEthereum:mainfrom May 4, 2026
Conversation
…tage 6 of leanEthereum#686) Per the multi-fork roadmap, test files that target fork-specific containers or fork choice belong next to the fork they exercise. Until the roadmap is finished, only lstar exists, so the tree starts as forks/lstar/{state, forkchoice}/. Each conftest moves with its only consumers: - containers/conftest.py provided container_key_manager, used solely by test_state_aggregation.py — both move to forks/lstar/state/. - forkchoice/conftest.py provided pruning_store and sample_store, used by tests now under forks/lstar/forkchoice/. The empty subspecs/forkchoice/ directory is removed. Files in subspecs/containers/ that target fork-stable types (test_checkpoint.py) or attestation containers stay where they are; Stage 6 was scoped to state and forkchoice tests only. The Stage 6 item that mirrors the structure under devnet5 is dropped because devnet5 was unified back into lstar. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per the multi-fork roadmap, Stage 6 reorganizes tests so files exercising fork-specific containers or fork choice live next to the fork they target. Only
lstarexists right now, so the new tree istests/lean_spec/forks/lstar/{state,forkchoice}/.tests/lean_spec/subspecs/containers/test_state_*.py(3 files)tests/lean_spec/forks/lstar/state/tests/lean_spec/subspecs/containers/conftest.pytests/lean_spec/forks/lstar/state/conftest.pytests/lean_spec/subspecs/forkchoice/*.py(7 tests + conftest)tests/lean_spec/forks/lstar/forkchoice/Conftests follow their only consumers:
container_key_manageris used solely bytest_state_aggregation.py— fixture moves with the test.pruning_storeandsample_storeare used only by tests inforkchoice/.The empty
subspecs/forkchoice/directory is removed. Files insubspecs/containers/that target fork-stable types (test_checkpoint.py) or attestation containers stay where they are; Stage 6 was scoped to state and forkchoice tests only.The third Stage 6 item — mirroring the structure under
devnet5/— is dropped because devnet5 was unified back into lstar.Test plan
uvx tox -e all-checks— ruff, format, ty, codespell, mdformat all passpytest tests/lean_spec/forks tests/lean_spec/subspecs/containers— 134 passed (targeted)pytest tests -n auto— 3291 passed (same total as before the move; no test lost)Tracks #686.
🤖 Generated with Claude Code