refactor(xmss/prf): drop redundant message length check#741
Merged
Conversation
The parameter is typed Bytes32, which enforces a 32-byte payload at construction. MESSAGE_LENGTH is also 32 in every prod and test config, so the runtime length check could never fire from the single internal call site. No test pinned the error message. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_randomnesstakesmessage: Bytes32, which enforces a 32-byte payload at construction time.MESSAGE_LENGTHis32in every production and test config, so the runtimelen(message) != config.MESSAGE_LENGTHbranch could never fire from the single internal call site (xmss/interface.py:285).Test plan
uv run pytest tests/lean_spec/subspecs/xmss/— 107 tests pass.🤖 Generated with Claude Code