refactor: PEP 695 generic syntax for SSZ collections and Store#744
Merged
Merged
Conversation
Convert SSZVector, SSZList, and the lstar Store to PEP 695 generic syntax. The bounds (T: SSZType, StateT/BlockT: Container) now live inline in the class header, dropping three module-level TypeVar blocks and the Generic and TypeVar imports across two files. Pydantic 2.12 emits identical __pydantic_generic_metadata__ under both syntaxes, so the element-type recovery helper in collections is unaffected. StateT and BlockT also leave __all__ since they are now class-scoped and unused outside the file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert
SSZVector,SSZList, andlstar.Storeto PEP 695 generic syntax. The bounds now live inline in the class header, dropping three module-levelTypeVarblocks and theGenericandTypeVarimports across two files.types/collections.py:class SSZVector[T: SSZType](SSZModel)andclass SSZList[T: SSZType](SSZModel).forks/lstar/store.py:class Store[StateT: Container, BlockT: Container](StrictBaseModel).StateTandBlockTare now class-scoped, so they also leave__all__(confirmed unused outside the file).Pydantic 2.12 emits identical
__pydantic_generic_metadata__under both syntaxes, so the element-type recovery helper incollections.pykeeps working unchanged. Verified with a probe before editing.Test plan
ruff check src/lean_spec/types/collections.py src/lean_spec/forks/lstar/store.py— clean.{'origin': ..., 'args': (...), 'parameters': ()}shape as old-styleGeneric[T].🤖 Generated with Claude Code