zkdsl compiler: remove the possibility for a range loop to mutate variables defined in external scope. Use manual buffers instead.#241
Merged
Conversation
…ariables defined in external scope. Use manual buffers instead.
TomWambsgans
added a commit
that referenced
this pull request
Jun 1, 2026
…ariables defined in external scope. Use manual buffers instead. (#241) * zkdsl compiler: remove the possibility for a `range` loop to mutate variables defined in external scope. Use manual buffers instead. * make tests pass --------- Co-authored-by: Tom Wambsgans <TomWambsgans@users.noreply.github.com>
TomWambsgans
added a commit
that referenced
this pull request
Jun 1, 2026
…241) `range`/`parallel_range` loops may no longer reassign an enclosing-scope mutable; accumulation must go through an explicit array buffer. Rewrite the affected gadgets and handwritten faithfulness tests to the array-chain idiom (acc[i+1] = acc[i] + x[i]), keeping their honest/violating models identical: - Loop gadget: single range-loop array-chain accumulator - NestedMutLoop gadget: two array chains across the nested loop (flat index), now exercising cross-iteration array data-dependencies instead of carried muts - handwritten cases 6,11,15,17,24,25,27,29,30: range-loop mutable accumulators rewritten to array chains (unroll-carried mutables remain allowed and unchanged) Validated by hard_kinds_isolate + the full compiler_fuzzer suite (40/40). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: