This repository was archived by the owner on Dec 20, 2017. It is now read-only.
Merged
Conversation
* 使用 `lc` 替代 `avoscloud` 命令。 * 使用 `lc up` 作为启动本地项目的命令,而不是之前的 `avoscloud` 回车。 * 使用 `lc app <add|checkout|rm>` 替代 `avoscloud <add|checkout|rm>` 。 * 程序执行时尽量不使用 `exitWith` 方法,防止一些统一的错误处理和 统计程序没有机会执行。 * 使用统一的 `request` 方法替代之前的 `ajax` 和 `requestCloud` 方法, 统一处理 http 响应,防止直接输出 html 片段。 * 在所有文案中,使用 `云引擎` 替代 `云代码`。 * 增加单元测试。 * 更新了 `avoscloud_completion.sh`
Contributor
Author
|
这改动太大,估计 github 上 review 不了。 |
Contributor
|
lc 这个命令名字感觉很容易冲突: https://msdn.microsoft.com/en-us/library/ha0k3c9f(v=vs.110).aspx 感觉还是 lean 比较好一些,也足够短了。 |
Contributor
|
冲突有啥解决办法么?我更倾向 |
Contributor
|
我也不太建议用 lc, 太短了易冲突,目前为止我们似乎也没在其他地方用这个缩写,还是叫 |
Contributor
Author
|
那我改成 lean 吧。 |
Contributor
|
恩, |
Member
|
|
Contributor
Author
|
更名完成。 |
bin/run.js
Outdated
| } | ||
| var latestVersion = body.version; | ||
| var changelog = body.changelog || '1.内部重构'; | ||
| if(latestVersion.localeCompare(version) > 0){ |
Contributor
There was a problem hiding this comment.
这里确实没有做 parseFloat ,转化成数字来比较,包括 version,建议改下。
类似静态代码检查工具很多,包括云引擎支持多语言, 所以这类工具用户自行选择。
Contributor
|
我在 4.0 上测试了所有新增功能,在 3.0 上测试了 deploy 和 publish, 没有发现问题。 |
sdjcw
added a commit
that referenced
this pull request
Mar 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lc替代avoscloud命令。lc up作为启动本地项目的命令,而不是之前的avoscloud回车。lc app <add|checkout|rm>替代avoscloud <add|checkout|rm>。exitWith方法,防止一些统一的错误处理和统计程序没有机会执行。
request方法替代之前的ajax和requestCloud方法,统一处理 http 响应,防止直接输出 html 片段。
云引擎替代云代码。avoscloud_completion.sh