implement AV.Object save options #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leeyeh
commented
Apr 5, 2016
leeyeh
commented
- 支持 save 时传入 options.query
- 支持 save 时传入 options.fetchWhenSave
- 废弃 AV.Object#fetchWhenSave（仍可用）
Current coverage is
|
| try { | ||
| json._where = options.query.toJSON().where; | ||
| } catch (e) { | ||
| var error = new Error('options.query is not an AV.Query'); |
Contributor
There was a problem hiding this comment.
这样处理错误不是很好呀，首先不应该认为只要有异常就是这个原因，然后原异常的调用栈被丢弃掉了，不方便调试。
Contributor
|
👍 |
| if (dataObject._where) { | ||
| apiURL += ('?where=' + encodeURIComponent(JSON.stringify(dataObject._where))); | ||
| delete dataObject._where; | ||
| } |
Contributor
There was a problem hiding this comment.
dataObject._fetchWhenSave 与 dataObject._where 会不会有同时存在的情况？如果有，apiURL 可能拼接会有问题。
Contributor
|
我 review 完了。 |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.