fix(Role): stop complaint about defaultACL when query Roles #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 65.43% 65.44% +0.01%
==========================================
Files 34 34
Lines 2847 2848 +1
==========================================
+ Hits 1863 1864 +1
Misses 984 984
Continue to review full report at Codecov.
|
tang3w
reviewed
May 31, 2017
| return new AV.Object(response.className); | ||
| } | ||
| return obj; | ||
| if (this.objectClass === AV.Role) { |
There was a problem hiding this comment.
只有通过 new AV.Role() 创建才会打印废弃日志吗？通过 new AV.Object('_Role') 创建会不会触发？如果也会触发，把这个判断提到上个 if 语句的前面会不会好些？
Contributor
Author
There was a problem hiding this comment.
其实 query 返回的 response.className 是没有的，所以理论上上面这个逻辑应该是走不到的。
There was a problem hiding this comment.
好的，如果确保任何时候 Role 查询的 response 中 className 都没有，就没有问题。
tang3w
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.leancloud.cn/t/to-create-a-role-without-acl/14841