refactor(AVObject): simplify get Created/UpdatedAt #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this.get('createdAt')` itself evaluates to
`this.createdAt`,
thus `this.createdAt || this.get('createdAt')` is unnecessary.
The same applies to `getUpdatedAt`.
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 68.86% 68.86%
=======================================
Files 37 37
Lines 3209 3209
=======================================
Hits 2210 2210
Misses 999 999
Continue to review full report at Codecov.
|
leeyeh
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.get('createdAt')itself evaluates tothis.createdAt,thus
this.createdAt || this.get('createdAt')is unnecessary.The same applies to
getUpdatedAt.