Skip to content

支持 beforeUpdate#31

Merged
jysperm merged 2 commits intoleancloud:masterfrom
jysperm:before-update
Oct 21, 2015
Merged

支持 beforeUpdate#31
jysperm merged 2 commits intoleancloud:masterfrom
jysperm:before-update

Conversation

@jysperm
Copy link
Copy Markdown
Contributor

@jysperm jysperm commented Oct 13, 2015

在 classHook(371 行)加了一个针对 beforeUpdate 的处理,是希望让 _updatedKeys 可以通过 object.updatedKeys 而不是 object.get('_updatedKeys') 来访问,这样看起来才像一个特殊的字段,而不是对象的属性。

#25

Comment thread test/hook_test.js Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最好能有个 error 的回调例子和测试。

@killme2008
Copy link
Copy Markdown
Contributor

@jysperm 这里我不是很赞同,因为 x._attr 一般表示 _attr 是一个隐藏属性,不建议使用。

@killme2008
Copy link
Copy Markdown
Contributor

👍 我没有问题了,请陈伟确认,尽快发布吧 @sdjcw

@sdjcw
Copy link
Copy Markdown
Contributor

sdjcw commented Oct 20, 2015

我也没什么问题了。确认测试没问题就合并吧。

jysperm added a commit that referenced this pull request Oct 21, 2015
@jysperm jysperm merged commit 3dc7e9f into leancloud:master Oct 21, 2015
@jysperm jysperm deleted the before-update branch October 21, 2015 02:01
@killme2008
Copy link
Copy Markdown
Contributor

记得正式发布后补充文档 @jysperm

@jysperm
Copy link
Copy Markdown
Contributor Author

jysperm commented Oct 21, 2015

文档在这里 https://github.com/leancloud/docs/pull/586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants